Replace 'ld' with Load
parent
deeacd917a
commit
29ccffccf7
44
src/run.rs
44
src/run.rs
|
@ -49,42 +49,42 @@ impl Processor {
|
|||
|
||||
fn run_8_bit_load(&mut self, instruction: &EightBitLoadInstruction) {
|
||||
match *instruction {
|
||||
EightBitLoadInstruction::LDImmediateToRegister { value, register } => {
|
||||
EightBitLoadInstruction::LoadImmediateToRegister { value, register } => {
|
||||
self.registers.set_single_8bit_register(register, value);
|
||||
}
|
||||
|
||||
EightBitLoadInstruction::LDBetweenRegisters { dst, src } => {
|
||||
EightBitLoadInstruction::LoadBetweenRegisters { dst, src } => {
|
||||
let src_value = self.registers.get_single_8bit_register(src);
|
||||
self.registers.set_single_8bit_register(dst, src_value);
|
||||
}
|
||||
|
||||
EightBitLoadInstruction::LDFromRegisterAddress { src, dst } => {
|
||||
EightBitLoadInstruction::LoadFromRegisterAddress { src, dst } => {
|
||||
let load_res = self.load_from_register_address_to_register(dst, src);
|
||||
assert_ok!(load_res);
|
||||
}
|
||||
|
||||
EightBitLoadInstruction::LDFromImmediateAddress { src_address, dst } => {
|
||||
EightBitLoadInstruction::LoadFromImmediateAddress { src_address, dst } => {
|
||||
let load_res = self.load_from_address_to_register(dst, src_address.into());
|
||||
assert_ok!(load_res);
|
||||
}
|
||||
|
||||
EightBitLoadInstruction::LDToRegisterAddress { src, dst } => {
|
||||
EightBitLoadInstruction::LoadToRegisterAddress { src, dst } => {
|
||||
let load_res = self.load_from_register_to_register_address(dst, src);
|
||||
assert_ok!(load_res);
|
||||
}
|
||||
|
||||
EightBitLoadInstruction::LDToImmediateAddress { src, dst_address } => {
|
||||
EightBitLoadInstruction::LoadToImmediateAddress { src, dst_address } => {
|
||||
let load_res = self.load_from_register_to_address(dst_address.into(), src);
|
||||
assert_ok!(load_res);
|
||||
}
|
||||
|
||||
EightBitLoadInstruction::LDnToHLAddress { value } => {
|
||||
EightBitLoadInstruction::LoadnToHLAddress { value } => {
|
||||
let dest_address = self.registers.get_combined_register(register::Combined::HL);
|
||||
let load_res = self.load_8bit_immediate_to_address(dest_address.into(), value);
|
||||
assert_ok!(load_res);
|
||||
}
|
||||
|
||||
EightBitLoadInstruction::LDFromMemoryRelativeToIORegisterStart {
|
||||
EightBitLoadInstruction::LoadFromMemoryRelativeToIORegisterStart {
|
||||
offset_register,
|
||||
dst,
|
||||
} => {
|
||||
|
@ -95,7 +95,7 @@ impl Processor {
|
|||
assert_ok!(load_res);
|
||||
}
|
||||
|
||||
EightBitLoadInstruction::LDToMemoryRelativeToIORegisterStart {
|
||||
EightBitLoadInstruction::LoadToMemoryRelativeToIORegisterStart {
|
||||
src,
|
||||
offset_register,
|
||||
} => {
|
||||
|
@ -106,7 +106,7 @@ impl Processor {
|
|||
assert_ok!(load_res);
|
||||
}
|
||||
|
||||
EightBitLoadInstruction::LDFromRegisterAddressThenDec { dst, src } => {
|
||||
EightBitLoadInstruction::LoadFromRegisterAddressThenDec { dst, src } => {
|
||||
let load_res = self.load_from_register_address_to_register(dst, src);
|
||||
assert_ok!(load_res);
|
||||
|
||||
|
@ -114,7 +114,7 @@ impl Processor {
|
|||
self.registers.set_combined_register(src, src_address - 1);
|
||||
}
|
||||
|
||||
EightBitLoadInstruction::LDFromRegisterAddressThenInc { dst, src } => {
|
||||
EightBitLoadInstruction::LoadFromRegisterAddressThenInc { dst, src } => {
|
||||
let load_res = self.load_from_register_address_to_register(dst, src);
|
||||
assert_ok!(load_res);
|
||||
|
||||
|
@ -122,7 +122,7 @@ impl Processor {
|
|||
self.registers.set_combined_register(src, src_address + 1);
|
||||
}
|
||||
|
||||
EightBitLoadInstruction::LDToRegisterAddressThenDec { dst, src } => {
|
||||
EightBitLoadInstruction::LoadToRegisterAddressThenDec { dst, src } => {
|
||||
let dst_address = self.registers.get_combined_register(dst);
|
||||
let load_res = self.load_from_register_to_address(dst_address.into(), src);
|
||||
assert_ok!(load_res);
|
||||
|
@ -130,7 +130,7 @@ impl Processor {
|
|||
self.registers.set_combined_register(dst, dst_address - 1);
|
||||
}
|
||||
|
||||
EightBitLoadInstruction::LDToRegisterAddressThenInc { dst, src } => {
|
||||
EightBitLoadInstruction::LoadToRegisterAddressThenInc { dst, src } => {
|
||||
let dst_address = self.registers.get_combined_register(dst);
|
||||
let load_res = self.load_from_register_to_address(dst_address.into(), src);
|
||||
assert_ok!(load_res);
|
||||
|
@ -138,7 +138,7 @@ impl Processor {
|
|||
self.registers.set_combined_register(dst, dst_address + 1);
|
||||
}
|
||||
|
||||
EightBitLoadInstruction::LDToMemoryRelativeToIORegisterStartByImmediate {
|
||||
EightBitLoadInstruction::LoadToMemoryRelativeToIORegisterStartByImmediate {
|
||||
src,
|
||||
offset,
|
||||
} => {
|
||||
|
@ -147,7 +147,7 @@ impl Processor {
|
|||
assert_ok!(load_res);
|
||||
}
|
||||
|
||||
EightBitLoadInstruction::LDFromMemoryRelativeToIORegisterStartByImmediate {
|
||||
EightBitLoadInstruction::LoadFromMemoryRelativeToIORegisterStartByImmediate {
|
||||
dst,
|
||||
offset,
|
||||
} => {
|
||||
|
@ -160,16 +160,16 @@ impl Processor {
|
|||
|
||||
fn run_16_bit_load(&mut self, instruction: &SixteenBitLoadInstruction) {
|
||||
match *instruction {
|
||||
SixteenBitLoadInstruction::LDImmediateToRegister { dst, value } => {
|
||||
SixteenBitLoadInstruction::LoadImmediateToRegister { dst, value } => {
|
||||
self.registers.set_16bit_register(dst, value);
|
||||
}
|
||||
|
||||
SixteenBitLoadInstruction::LDBetweenRegisters { dst, src } => {
|
||||
SixteenBitLoadInstruction::LoadBetweenRegisters { dst, src } => {
|
||||
let value = self.registers.get_16bit_register(src);
|
||||
self.registers.set_16bit_register(dst, value);
|
||||
}
|
||||
|
||||
SixteenBitLoadInstruction::LDEffectiveAddress { dst, offset } => {
|
||||
SixteenBitLoadInstruction::LoadEffectiveAddress { dst, offset } => {
|
||||
let current_sp = self
|
||||
.registers
|
||||
.get_single_16bit_register(register::SingleSixteenBit::StackPointer);
|
||||
|
@ -355,9 +355,9 @@ mod tests {
|
|||
#[test_case(0x1E, register::SingleEightBit::E)]
|
||||
#[test_case(0x26, register::SingleEightBit::H)]
|
||||
#[test_case(0x2E, register::SingleEightBit::L)]
|
||||
fn test_load_immediate(ld_opcode: u8, expected_register: register::SingleEightBit) {
|
||||
fn test_load_immediate(load_opcode: u8, expected_register: register::SingleEightBit) {
|
||||
let mut processor = Processor::default();
|
||||
let data = [ld_opcode, 0x23, 0x00, 0x01];
|
||||
let data = [load_opcode, 0x23, 0x00, 0x01];
|
||||
let (ins, extra_data) =
|
||||
RunnableInstruction::from_data(&data).expect("could not parse instruction");
|
||||
|
||||
|
@ -425,7 +425,7 @@ mod tests {
|
|||
#[test_case(0x67, register::SingleEightBit::H, register::SingleEightBit::A)]
|
||||
#[test_case(0x6F, register::SingleEightBit::L, register::SingleEightBit::A)]
|
||||
fn test_load_register(
|
||||
ld_opcode: u8,
|
||||
load_opcode: u8,
|
||||
dst_register: register::SingleEightBit,
|
||||
src_register: register::SingleEightBit,
|
||||
) {
|
||||
|
@ -434,7 +434,7 @@ mod tests {
|
|||
.registers
|
||||
.set_single_8bit_register(src_register, 0x45);
|
||||
|
||||
let data = [ld_opcode, 0x00];
|
||||
let data = [load_opcode, 0x00];
|
||||
let (ins, extra_data) =
|
||||
RunnableInstruction::from_data(&data).expect("could not parse instruction");
|
||||
|
||||
|
|
|
@ -5,17 +5,17 @@ use crate::register;
|
|||
#[derive(Debug, Clone)]
|
||||
pub enum SixteenBitLoadInstruction {
|
||||
// 3.3.2.1
|
||||
LDImmediateToRegister {
|
||||
LoadImmediateToRegister {
|
||||
value: u16,
|
||||
dst: register::SixteenBit,
|
||||
},
|
||||
// 3.3.2.2
|
||||
LDBetweenRegisters {
|
||||
LoadBetweenRegisters {
|
||||
dst: register::SixteenBit,
|
||||
src: register::SixteenBit,
|
||||
},
|
||||
// 3.3.3.4
|
||||
LDEffectiveAddress {
|
||||
LoadEffectiveAddress {
|
||||
dst: register::Combined,
|
||||
offset: i8,
|
||||
},
|
||||
|
|
|
@ -5,89 +5,89 @@ use crate::register;
|
|||
#[derive(Debug, Clone)]
|
||||
pub enum EightBitLoadInstruction {
|
||||
// 3.3.1.1
|
||||
LDImmediateToRegister {
|
||||
LoadImmediateToRegister {
|
||||
value: u8,
|
||||
register: register::SingleEightBit,
|
||||
},
|
||||
// 3.3.1.2, excluding the (hl) instructions, 3.3.1.3, excluding the (nn) instructions
|
||||
// and 3.3.1.4 excluding the (nn) instructions
|
||||
LDBetweenRegisters {
|
||||
LoadBetweenRegisters {
|
||||
dst: register::SingleEightBit,
|
||||
src: register::SingleEightBit,
|
||||
},
|
||||
// 3.3.1.2/3.3.1.3, only the loading from (nn) instructions
|
||||
LDFromRegisterAddress {
|
||||
LoadFromRegisterAddress {
|
||||
// src, unlike some of the other instructions, is a 16bit combined register that will be
|
||||
// dereferenced to get the value to place into the dst register
|
||||
src: register::Combined,
|
||||
dst: register::SingleEightBit,
|
||||
},
|
||||
// 3.3.1.5 - load to register relative to $FF00 (the address of the i/o registers)
|
||||
LDFromMemoryRelativeToIORegisterStart {
|
||||
LoadFromMemoryRelativeToIORegisterStart {
|
||||
// A register whose value will be used to get the address relative to FF00
|
||||
offset_register: register::SingleEightBit,
|
||||
dst: register::SingleEightBit,
|
||||
},
|
||||
// 3.3.1.6 - load to memory relative to $FF00 (the address of the i/o registers)
|
||||
LDToMemoryRelativeToIORegisterStart {
|
||||
LoadToMemoryRelativeToIORegisterStart {
|
||||
src: register::SingleEightBit,
|
||||
// A register whose value will be used to get the address relative to FF00
|
||||
offset_register: register::SingleEightBit,
|
||||
},
|
||||
// 3.3.1.20
|
||||
LDFromMemoryRelativeToIORegisterStartByImmediate {
|
||||
LoadFromMemoryRelativeToIORegisterStartByImmediate {
|
||||
dst: register::SingleEightBit,
|
||||
offset: u8,
|
||||
},
|
||||
// 3.3.1.19
|
||||
LDToMemoryRelativeToIORegisterStartByImmediate {
|
||||
LoadToMemoryRelativeToIORegisterStartByImmediate {
|
||||
offset: u8,
|
||||
src: register::SingleEightBit,
|
||||
},
|
||||
LDFromImmediateAddress {
|
||||
LoadFromImmediateAddress {
|
||||
src_address: u16,
|
||||
dst: register::SingleEightBit,
|
||||
},
|
||||
// 3.3.1.2, only the loading to (hl) instructions
|
||||
// 3.3.1.4, only the loading to (nn) instructions
|
||||
LDToRegisterAddress {
|
||||
LoadToRegisterAddress {
|
||||
src: register::SingleEightBit,
|
||||
// dst, unlike some other instructions, is a 16bit combined register that holds
|
||||
// the address we will write the value to
|
||||
dst: register::Combined,
|
||||
},
|
||||
// 3.3.1.4, only the loading to (nn) immediate instrution
|
||||
LDToImmediateAddress {
|
||||
LoadToImmediateAddress {
|
||||
src: register::SingleEightBit,
|
||||
dst_address: u16,
|
||||
},
|
||||
// 3.3.1.2, but the (hl), n instruction [why is this in this section? it's so out of place]
|
||||
LDnToHLAddress {
|
||||
LoadnToHLAddress {
|
||||
value: u8,
|
||||
},
|
||||
// 3.3.1.{7,8,9}
|
||||
LDFromRegisterAddressThenDec {
|
||||
LoadFromRegisterAddressThenDec {
|
||||
// The src, unlike some other destination instructions, refers to a register
|
||||
// whose address will be dereferenced (and then decremented after the load)
|
||||
src: register::Combined,
|
||||
dst: register::SingleEightBit,
|
||||
},
|
||||
// 3.3.1.{13,14,15}
|
||||
LDFromRegisterAddressThenInc {
|
||||
LoadFromRegisterAddressThenInc {
|
||||
// The src, unlike some other destination instructions, refers to a register
|
||||
// whose address will be dereferenced (and then incremented after the load)
|
||||
src: register::Combined,
|
||||
dst: register::SingleEightBit,
|
||||
},
|
||||
// 3.3.1.{10,11,12}
|
||||
LDToRegisterAddressThenDec {
|
||||
LoadToRegisterAddressThenDec {
|
||||
src: register::SingleEightBit,
|
||||
// The destination, unlike some other destination instructions, refers to a register
|
||||
// whose address will be dereferenced (and then decremented after the load)
|
||||
dst: register::Combined,
|
||||
},
|
||||
// 3.3.1.{16,17,18}
|
||||
LDToRegisterAddressThenInc {
|
||||
LoadToRegisterAddressThenInc {
|
||||
src: register::SingleEightBit,
|
||||
// The destination, unlike some other destination instructions, refers to a register
|
||||
// whose address will be dereferenced (and then incremented after the load)
|
||||
|
|
|
@ -45,7 +45,7 @@ fn make_load_immediate_data(dst: register::SixteenBit, data: &[u8]) -> ParseResu
|
|||
Ok((
|
||||
RunnableInstruction {
|
||||
instruction: Instruction::SixteenBitLoad(
|
||||
SixteenBitLoadInstruction::LDImmediateToRegister { value, dst },
|
||||
SixteenBitLoadInstruction::LoadImmediateToRegister { value, dst },
|
||||
),
|
||||
cycles: 12,
|
||||
},
|
||||
|
@ -75,7 +75,7 @@ fn make_load_effective_address(dst: register::Combined, data: &[u8]) -> ParseRes
|
|||
Ok((
|
||||
RunnableInstruction {
|
||||
instruction: Instruction::SixteenBitLoad(
|
||||
SixteenBitLoadInstruction::LDEffectiveAddress {
|
||||
SixteenBitLoadInstruction::LoadEffectiveAddress {
|
||||
dst,
|
||||
offset: signed_value,
|
||||
},
|
||||
|
|
|
@ -13,7 +13,7 @@ impl OpcodeParser for Between16BitRegisterParser {
|
|||
fn parse_opcode(data: &[u8]) -> ParseResult {
|
||||
let opcode = parse::get_opcode_from_data(data)?;
|
||||
match opcode {
|
||||
0xF9 => make_ld_between_register_data(
|
||||
0xF9 => make_load_between_register_data(
|
||||
register::SixteenBit::Single(register::SingleSixteenBit::StackPointer),
|
||||
register::SixteenBit::Combined(register::Combined::HL),
|
||||
data,
|
||||
|
@ -23,7 +23,7 @@ impl OpcodeParser for Between16BitRegisterParser {
|
|||
}
|
||||
}
|
||||
|
||||
fn make_ld_between_register_data(
|
||||
fn make_load_between_register_data(
|
||||
dst: register::SixteenBit,
|
||||
src: register::SixteenBit,
|
||||
data: &[u8],
|
||||
|
@ -33,7 +33,7 @@ fn make_ld_between_register_data(
|
|||
(
|
||||
RunnableInstruction {
|
||||
instruction: Instruction::SixteenBitLoad(
|
||||
SixteenBitLoadInstruction::LDBetweenRegisters { dst, src },
|
||||
SixteenBitLoadInstruction::LoadBetweenRegisters { dst, src },
|
||||
),
|
||||
cycles: 4,
|
||||
},
|
||||
|
|
|
@ -36,7 +36,7 @@ fn make_load_immediate_data(register: register::SingleEightBit, data: &[u8]) ->
|
|||
Ok((
|
||||
RunnableInstruction {
|
||||
instruction: Instruction::EightBitLoad(
|
||||
EightBitLoadInstruction::LDImmediateToRegister {
|
||||
EightBitLoadInstruction::LoadImmediateToRegister {
|
||||
register,
|
||||
value: *value,
|
||||
},
|
||||
|
|
|
@ -34,31 +34,31 @@ fn parse_load_from_register_to_address(data: &[u8]) -> ParseResult {
|
|||
let opcode = parse::get_opcode_from_data(data)?;
|
||||
match opcode {
|
||||
0x02 => {
|
||||
make_ld_to_register_address(register::Combined::BC, register::SingleEightBit::A, data)
|
||||
make_load_to_register_address(register::Combined::BC, register::SingleEightBit::A, data)
|
||||
}
|
||||
0x12 => {
|
||||
make_ld_to_register_address(register::Combined::DE, register::SingleEightBit::A, data)
|
||||
make_load_to_register_address(register::Combined::DE, register::SingleEightBit::A, data)
|
||||
}
|
||||
0x70 => {
|
||||
make_ld_to_register_address(register::Combined::HL, register::SingleEightBit::B, data)
|
||||
make_load_to_register_address(register::Combined::HL, register::SingleEightBit::B, data)
|
||||
}
|
||||
0x71 => {
|
||||
make_ld_to_register_address(register::Combined::HL, register::SingleEightBit::C, data)
|
||||
make_load_to_register_address(register::Combined::HL, register::SingleEightBit::C, data)
|
||||
}
|
||||
0x72 => {
|
||||
make_ld_to_register_address(register::Combined::HL, register::SingleEightBit::D, data)
|
||||
make_load_to_register_address(register::Combined::HL, register::SingleEightBit::D, data)
|
||||
}
|
||||
0x73 => {
|
||||
make_ld_to_register_address(register::Combined::HL, register::SingleEightBit::E, data)
|
||||
make_load_to_register_address(register::Combined::HL, register::SingleEightBit::E, data)
|
||||
}
|
||||
0x74 => {
|
||||
make_ld_to_register_address(register::Combined::HL, register::SingleEightBit::H, data)
|
||||
make_load_to_register_address(register::Combined::HL, register::SingleEightBit::H, data)
|
||||
}
|
||||
0x75 => {
|
||||
make_ld_to_register_address(register::Combined::HL, register::SingleEightBit::L, data)
|
||||
make_load_to_register_address(register::Combined::HL, register::SingleEightBit::L, data)
|
||||
}
|
||||
0x77 => {
|
||||
make_ld_to_register_address(register::Combined::HL, register::SingleEightBit::A, data)
|
||||
make_load_to_register_address(register::Combined::HL, register::SingleEightBit::A, data)
|
||||
}
|
||||
_ => Err(Error::UnknownOpcode(opcode)),
|
||||
}
|
||||
|
@ -67,49 +67,67 @@ fn parse_load_from_register_to_address(data: &[u8]) -> ParseResult {
|
|||
fn parse_load_from_address_to_register(data: &[u8]) -> ParseResult {
|
||||
let opcode = parse::get_opcode_from_data(data)?;
|
||||
match opcode {
|
||||
0x0A => {
|
||||
make_ld_from_register_address(register::SingleEightBit::A, register::Combined::BC, data)
|
||||
}
|
||||
0x1A => {
|
||||
make_ld_from_register_address(register::SingleEightBit::A, register::Combined::DE, data)
|
||||
}
|
||||
0x46 => {
|
||||
make_ld_from_register_address(register::SingleEightBit::B, register::Combined::HL, data)
|
||||
}
|
||||
0x4E => {
|
||||
make_ld_from_register_address(register::SingleEightBit::C, register::Combined::HL, data)
|
||||
}
|
||||
0x56 => {
|
||||
make_ld_from_register_address(register::SingleEightBit::D, register::Combined::HL, data)
|
||||
}
|
||||
0x5E => {
|
||||
make_ld_from_register_address(register::SingleEightBit::E, register::Combined::HL, data)
|
||||
}
|
||||
0x66 => {
|
||||
make_ld_from_register_address(register::SingleEightBit::H, register::Combined::HL, data)
|
||||
}
|
||||
0x6E => {
|
||||
make_ld_from_register_address(register::SingleEightBit::L, register::Combined::HL, data)
|
||||
}
|
||||
0x7E => {
|
||||
make_ld_from_register_address(register::SingleEightBit::A, register::Combined::HL, data)
|
||||
}
|
||||
0x0A => make_load_from_register_address(
|
||||
register::SingleEightBit::A,
|
||||
register::Combined::BC,
|
||||
data,
|
||||
),
|
||||
0x1A => make_load_from_register_address(
|
||||
register::SingleEightBit::A,
|
||||
register::Combined::DE,
|
||||
data,
|
||||
),
|
||||
0x46 => make_load_from_register_address(
|
||||
register::SingleEightBit::B,
|
||||
register::Combined::HL,
|
||||
data,
|
||||
),
|
||||
0x4E => make_load_from_register_address(
|
||||
register::SingleEightBit::C,
|
||||
register::Combined::HL,
|
||||
data,
|
||||
),
|
||||
0x56 => make_load_from_register_address(
|
||||
register::SingleEightBit::D,
|
||||
register::Combined::HL,
|
||||
data,
|
||||
),
|
||||
0x5E => make_load_from_register_address(
|
||||
register::SingleEightBit::E,
|
||||
register::Combined::HL,
|
||||
data,
|
||||
),
|
||||
0x66 => make_load_from_register_address(
|
||||
register::SingleEightBit::H,
|
||||
register::Combined::HL,
|
||||
data,
|
||||
),
|
||||
0x6E => make_load_from_register_address(
|
||||
register::SingleEightBit::L,
|
||||
register::Combined::HL,
|
||||
data,
|
||||
),
|
||||
0x7E => make_load_from_register_address(
|
||||
register::SingleEightBit::A,
|
||||
register::Combined::HL,
|
||||
data,
|
||||
),
|
||||
|
||||
0xF2 => make_ld_from_memory_relative_to_io_register_start(
|
||||
0xF2 => make_load_from_memory_relative_to_io_register_start(
|
||||
register::SingleEightBit::C,
|
||||
register::SingleEightBit::A,
|
||||
data,
|
||||
),
|
||||
0xE2 => make_ld_to_memory_relative_to_io_register_start(
|
||||
0xE2 => make_load_to_memory_relative_to_io_register_start(
|
||||
register::SingleEightBit::C,
|
||||
register::SingleEightBit::A,
|
||||
data,
|
||||
),
|
||||
0xF0 => make_ld_from_memory_relative_to_io_register_start_by_immediate(
|
||||
0xF0 => make_load_from_memory_relative_to_io_register_start_by_immediate(
|
||||
register::SingleEightBit::A,
|
||||
data,
|
||||
),
|
||||
0xE0 => make_ld_to_memory_relative_to_io_register_start_by_immediate(
|
||||
0xE0 => make_load_to_memory_relative_to_io_register_start_by_immediate(
|
||||
register::SingleEightBit::A,
|
||||
data,
|
||||
),
|
||||
|
@ -121,9 +139,9 @@ fn parse_load_from_address_to_register(data: &[u8]) -> ParseResult {
|
|||
fn parse_load_immediate_instructions(data: &[u8]) -> ParseResult {
|
||||
let opcode = parse::get_opcode_from_data(data)?;
|
||||
match opcode {
|
||||
0x36 => make_ld_n_to_hl_address(data),
|
||||
0xFA => make_ld_from_immediate_address(register::SingleEightBit::A, data),
|
||||
0xEA => make_ld_to_immediate_address(register::SingleEightBit::A, data),
|
||||
0x36 => make_load_n_to_hl_address(data),
|
||||
0xFA => make_load_from_immediate_address(register::SingleEightBit::A, data),
|
||||
0xEA => make_load_to_immediate_address(register::SingleEightBit::A, data),
|
||||
_ => Err(Error::UnknownOpcode(opcode)),
|
||||
}
|
||||
}
|
||||
|
@ -131,35 +149,35 @@ fn parse_load_immediate_instructions(data: &[u8]) -> ParseResult {
|
|||
fn parse_load_from_register_to_address_and_do_arithmetic(data: &[u8]) -> ParseResult {
|
||||
let opcode = parse::get_opcode_from_data(data)?;
|
||||
match opcode {
|
||||
0x32 => make_ld_to_address_and_do_arithmetic(
|
||||
0x32 => make_load_to_address_and_do_arithmetic(
|
||||
register::Combined::HL,
|
||||
register::SingleEightBit::A,
|
||||
|dst, src| EightBitLoadInstruction::LDToRegisterAddressThenDec { dst, src },
|
||||
|dst, src| EightBitLoadInstruction::LoadToRegisterAddressThenDec { dst, src },
|
||||
data,
|
||||
),
|
||||
0x22 => make_ld_to_address_and_do_arithmetic(
|
||||
0x22 => make_load_to_address_and_do_arithmetic(
|
||||
register::Combined::HL,
|
||||
register::SingleEightBit::A,
|
||||
|dst, src| EightBitLoadInstruction::LDToRegisterAddressThenInc { dst, src },
|
||||
|dst, src| EightBitLoadInstruction::LoadToRegisterAddressThenInc { dst, src },
|
||||
data,
|
||||
),
|
||||
0x3A => make_ld_from_address_and_do_arithmetic(
|
||||
0x3A => make_load_from_address_and_do_arithmetic(
|
||||
register::SingleEightBit::A,
|
||||
register::Combined::HL,
|
||||
|dst, src| EightBitLoadInstruction::LDFromRegisterAddressThenDec { dst, src },
|
||||
|dst, src| EightBitLoadInstruction::LoadFromRegisterAddressThenDec { dst, src },
|
||||
data,
|
||||
),
|
||||
0x2A => make_ld_from_address_and_do_arithmetic(
|
||||
0x2A => make_load_from_address_and_do_arithmetic(
|
||||
register::SingleEightBit::A,
|
||||
register::Combined::HL,
|
||||
|dst, src| EightBitLoadInstruction::LDFromRegisterAddressThenInc { dst, src },
|
||||
|dst, src| EightBitLoadInstruction::LoadFromRegisterAddressThenInc { dst, src },
|
||||
data,
|
||||
),
|
||||
_ => Err(Error::UnknownOpcode(opcode)),
|
||||
}
|
||||
}
|
||||
|
||||
fn make_ld_from_register_address(
|
||||
fn make_load_from_register_address(
|
||||
dst: register::SingleEightBit,
|
||||
src: register::Combined,
|
||||
data: &[u8],
|
||||
|
@ -169,7 +187,7 @@ fn make_ld_from_register_address(
|
|||
(
|
||||
RunnableInstruction {
|
||||
instruction: Instruction::EightBitLoad(
|
||||
EightBitLoadInstruction::LDFromRegisterAddress { src, dst },
|
||||
EightBitLoadInstruction::LoadFromRegisterAddress { src, dst },
|
||||
),
|
||||
cycles: 8,
|
||||
},
|
||||
|
@ -179,7 +197,7 @@ fn make_ld_from_register_address(
|
|||
.ok_or(Error::NoData)
|
||||
}
|
||||
|
||||
fn make_ld_to_register_address(
|
||||
fn make_load_to_register_address(
|
||||
dst: register::Combined,
|
||||
src: register::SingleEightBit,
|
||||
data: &[u8],
|
||||
|
@ -189,7 +207,7 @@ fn make_ld_to_register_address(
|
|||
(
|
||||
RunnableInstruction {
|
||||
instruction: Instruction::EightBitLoad(
|
||||
EightBitLoadInstruction::LDToRegisterAddress { src, dst },
|
||||
EightBitLoadInstruction::LoadToRegisterAddress { src, dst },
|
||||
),
|
||||
cycles: 8,
|
||||
},
|
||||
|
@ -199,7 +217,7 @@ fn make_ld_to_register_address(
|
|||
.ok_or(Error::NoData)
|
||||
}
|
||||
|
||||
fn make_ld_from_immediate_address(dst: register::SingleEightBit, data: &[u8]) -> ParseResult {
|
||||
fn make_load_from_immediate_address(dst: register::SingleEightBit, data: &[u8]) -> ParseResult {
|
||||
let opcode = parse::get_opcode_from_data(data)?;
|
||||
let args = data.get(1..=2).ok_or(Error::NotEnoughArgs(opcode))?;
|
||||
|
||||
|
@ -208,7 +226,7 @@ fn make_ld_from_immediate_address(dst: register::SingleEightBit, data: &[u8]) ->
|
|||
Ok((
|
||||
RunnableInstruction {
|
||||
instruction: Instruction::EightBitLoad(
|
||||
EightBitLoadInstruction::LDFromImmediateAddress { src_address, dst },
|
||||
EightBitLoadInstruction::LoadFromImmediateAddress { src_address, dst },
|
||||
),
|
||||
cycles: 16,
|
||||
},
|
||||
|
@ -217,7 +235,7 @@ fn make_ld_from_immediate_address(dst: register::SingleEightBit, data: &[u8]) ->
|
|||
))
|
||||
}
|
||||
|
||||
fn make_ld_to_immediate_address(src: register::SingleEightBit, data: &[u8]) -> ParseResult {
|
||||
fn make_load_to_immediate_address(src: register::SingleEightBit, data: &[u8]) -> ParseResult {
|
||||
let opcode = parse::get_opcode_from_data(data)?;
|
||||
let args = data.get(1..=2).ok_or(Error::NotEnoughArgs(opcode))?;
|
||||
|
||||
|
@ -225,10 +243,9 @@ fn make_ld_to_immediate_address(src: register::SingleEightBit, data: &[u8]) -> P
|
|||
let dst_address = u16::from_le_bytes([args[0], args[1]]);
|
||||
Ok((
|
||||
RunnableInstruction {
|
||||
instruction: Instruction::EightBitLoad(EightBitLoadInstruction::LDToImmediateAddress {
|
||||
src,
|
||||
dst_address,
|
||||
}),
|
||||
instruction: Instruction::EightBitLoad(
|
||||
EightBitLoadInstruction::LoadToImmediateAddress { src, dst_address },
|
||||
),
|
||||
cycles: 16,
|
||||
},
|
||||
// This can't fail if get(1..=2) passed
|
||||
|
@ -236,12 +253,12 @@ fn make_ld_to_immediate_address(src: register::SingleEightBit, data: &[u8]) -> P
|
|||
))
|
||||
}
|
||||
|
||||
fn make_ld_n_to_hl_address(data: &[u8]) -> ParseResult {
|
||||
fn make_load_n_to_hl_address(data: &[u8]) -> ParseResult {
|
||||
let opcode = parse::get_opcode_from_data(data)?;
|
||||
let value = data.get(1).ok_or(Error::NotEnoughArgs(opcode))?;
|
||||
Ok((
|
||||
RunnableInstruction {
|
||||
instruction: Instruction::EightBitLoad(EightBitLoadInstruction::LDnToHLAddress {
|
||||
instruction: Instruction::EightBitLoad(EightBitLoadInstruction::LoadnToHLAddress {
|
||||
value: *value,
|
||||
}),
|
||||
cycles: 12,
|
||||
|
@ -251,7 +268,7 @@ fn make_ld_n_to_hl_address(data: &[u8]) -> ParseResult {
|
|||
))
|
||||
}
|
||||
|
||||
fn make_ld_from_memory_relative_to_io_register_start(
|
||||
fn make_load_from_memory_relative_to_io_register_start(
|
||||
offset_register: register::SingleEightBit,
|
||||
dst: register::SingleEightBit,
|
||||
data: &[u8],
|
||||
|
@ -261,7 +278,7 @@ fn make_ld_from_memory_relative_to_io_register_start(
|
|||
(
|
||||
RunnableInstruction {
|
||||
instruction: Instruction::EightBitLoad(
|
||||
EightBitLoadInstruction::LDFromMemoryRelativeToIORegisterStart {
|
||||
EightBitLoadInstruction::LoadFromMemoryRelativeToIORegisterStart {
|
||||
offset_register,
|
||||
dst,
|
||||
},
|
||||
|
@ -275,7 +292,7 @@ fn make_ld_from_memory_relative_to_io_register_start(
|
|||
.ok_or(Error::NoData)
|
||||
}
|
||||
|
||||
fn make_ld_to_memory_relative_to_io_register_start(
|
||||
fn make_load_to_memory_relative_to_io_register_start(
|
||||
offset_register: register::SingleEightBit,
|
||||
src: register::SingleEightBit,
|
||||
data: &[u8],
|
||||
|
@ -285,7 +302,7 @@ fn make_ld_to_memory_relative_to_io_register_start(
|
|||
(
|
||||
RunnableInstruction {
|
||||
instruction: Instruction::EightBitLoad(
|
||||
EightBitLoadInstruction::LDToMemoryRelativeToIORegisterStart {
|
||||
EightBitLoadInstruction::LoadToMemoryRelativeToIORegisterStart {
|
||||
src,
|
||||
offset_register,
|
||||
},
|
||||
|
@ -299,7 +316,7 @@ fn make_ld_to_memory_relative_to_io_register_start(
|
|||
.ok_or(Error::NoData)
|
||||
}
|
||||
|
||||
fn make_ld_to_memory_relative_to_io_register_start_by_immediate(
|
||||
fn make_load_to_memory_relative_to_io_register_start_by_immediate(
|
||||
src: register::SingleEightBit,
|
||||
data: &[u8],
|
||||
) -> ParseResult {
|
||||
|
@ -309,7 +326,7 @@ fn make_ld_to_memory_relative_to_io_register_start_by_immediate(
|
|||
Ok((
|
||||
RunnableInstruction {
|
||||
instruction: Instruction::EightBitLoad(
|
||||
EightBitLoadInstruction::LDToMemoryRelativeToIORegisterStartByImmediate {
|
||||
EightBitLoadInstruction::LoadToMemoryRelativeToIORegisterStartByImmediate {
|
||||
src,
|
||||
offset: *value,
|
||||
},
|
||||
|
@ -321,7 +338,7 @@ fn make_ld_to_memory_relative_to_io_register_start_by_immediate(
|
|||
))
|
||||
}
|
||||
|
||||
fn make_ld_from_memory_relative_to_io_register_start_by_immediate(
|
||||
fn make_load_from_memory_relative_to_io_register_start_by_immediate(
|
||||
dst: register::SingleEightBit,
|
||||
data: &[u8],
|
||||
) -> ParseResult {
|
||||
|
@ -331,7 +348,7 @@ fn make_ld_from_memory_relative_to_io_register_start_by_immediate(
|
|||
Ok((
|
||||
RunnableInstruction {
|
||||
instruction: Instruction::EightBitLoad(
|
||||
EightBitLoadInstruction::LDFromMemoryRelativeToIORegisterStartByImmediate {
|
||||
EightBitLoadInstruction::LoadFromMemoryRelativeToIORegisterStartByImmediate {
|
||||
offset: *value,
|
||||
dst,
|
||||
},
|
||||
|
@ -343,9 +360,9 @@ fn make_ld_from_memory_relative_to_io_register_start_by_immediate(
|
|||
))
|
||||
}
|
||||
|
||||
/// `make_ld_to_address_and_do_arithmetic` will make one of the instructions that load to memory and either increment
|
||||
/// `make_load_to_address_and_do_arithmetic` will make one of the instructions that load to memory and either increment
|
||||
/// or decerement. The instruction itself will be produced by the given `make` function.
|
||||
fn make_ld_to_address_and_do_arithmetic<
|
||||
fn make_load_to_address_and_do_arithmetic<
|
||||
F: Fn(register::Combined, register::SingleEightBit) -> EightBitLoadInstruction,
|
||||
>(
|
||||
dst: register::Combined,
|
||||
|
@ -356,9 +373,9 @@ fn make_ld_to_address_and_do_arithmetic<
|
|||
make_load_and_do_arithmetic(|| make(dst, src), data)
|
||||
}
|
||||
|
||||
/// `make_ld_to_address_and_do_arithmetic` will make one of the instructions that load from memory and either increment
|
||||
/// `make_load_to_address_and_do_arithmetic` will make one of the instructions that load from memory and either increment
|
||||
/// or decerement. The instruction itself will be produced by the given `make` function.
|
||||
fn make_ld_from_address_and_do_arithmetic<
|
||||
fn make_load_from_address_and_do_arithmetic<
|
||||
F: Fn(register::SingleEightBit, register::Combined) -> EightBitLoadInstruction,
|
||||
>(
|
||||
dst: register::SingleEightBit,
|
||||
|
|
|
@ -89,7 +89,7 @@ fn make_load_between_register_data(
|
|||
(
|
||||
RunnableInstruction {
|
||||
instruction: Instruction::EightBitLoad(
|
||||
EightBitLoadInstruction::LDBetweenRegisters { dst, src },
|
||||
EightBitLoadInstruction::LoadBetweenRegisters { dst, src },
|
||||
),
|
||||
cycles: 4,
|
||||
},
|
||||
|
|
Loading…
Reference in New Issue